Fixed Hyphen Issue (Issue #180)#181
Open
andrewozimek wants to merge 1 commit into
Open
Conversation
andrewozimek
changed the title
andrewozimek
changed the title
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#180
Fixed the bug where long hyphens (16+) were vanishing.
Turns out it was hitting a hard limit in HarfBuzz/Kitty. We were using GSUB to swap ligatures for a string of spaces to get the width right, but that caps out at 15 glyphs. Anything longer just failed silently.
The fix was simple: I stopped the ccmp expansion and just set the advance width directly on the glyph. The art is already the right size, so now it just works without the extra steps. This covers arrows, hyphens, and whatever else, regardless of length.